-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render schema attributes if attributes object is passed in GET /schema/all
#1763
Render schema attributes if attributes object is passed in GET /schema/all
#1763
Conversation
Hi @Rassl, @tomsmith8 |
Same me side: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shoaibdev7 looks like there is misundertanding, we should not update all schema in store, only here src/components/ModalsContainer/BlueprintModal/Body/Editor/CustomAttributesStep/FormInput/index.tsx and here src/components/AddItemModal/SetAttributesStep/index.tsx we should render props either from attributes, or the old way
@@ -43,7 +43,18 @@ export const Body = () => { | |||
|
|||
const filteredSchemas = response.schemas.filter((i) => i.ref_id && !i.is_deleted) | |||
|
|||
setSchemaAll(filteredSchemas.length > 0 ? filteredSchemas : response.schemas) | |||
const processedSchemas = filteredSchemas.map((schema) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not what we need to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rassl, Ok i check it and fix it
Hi @Rassl Please review this PR. |
@Rassl Please review this PR. |
@Rassl How we looking on this one. I noticed today However response is:
Therefore should jsut render attributes |
@tomsmith8, I think we should also hide |
No, we should only render whats inside 'attributes' Then we don't have to do manual checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem:
attributes
property is passed, only renderattributes
inside objectcloses: #1756
Issue ticket number and link:
attributes
object is passed inGET /schema/all
#1756]Evidence: